Remove the upgradeReq property

[lpinca]

This removes the upgradeReq property from the WebSocket object. The http.IncomingMessage object is instead passed as the second argument to the connection event.

In this way most of the memory retained by the http.IncomingMessage object can be GC'ed reducing memory usage by ~20%.

Developers can save only the required info or the whole http.IncomingMessage object, if they have to, when the event is emitted.

[3rd-Eden]

This is a major breaking change tho.

[lpinca]

This is indeed a big change. It will break a lot of existing code, but along with nodejs/node#11926 will greatly reduce memory usage.

In the worst case scenario all is needed to bring back the old behavior is this:

wss.on('connection', (ws, req) => {
  ws.upgradeReq = req;
});

Currently the opposite is needed to free the memory.

wss.on('connection', (ws) => {
  ws.upgradeReq = null;
});

Basically it will make the feature opt-in instead of opt-out.

[lpinca]

Ops, I deleted the branch instead of force pushing 😄.
Reopened as #1104.

[projetoarduino]

Hi

Where is sec-websocket-key

[lpinca]

@projetoarduino in the req object.

wss.on('connection', (ws, req) => {
  const key = req.headers['sec-websocket-key'];
});

[projetoarduino]

Thanks my friend.

[projetoarduino]

Hi, this method work, but i need one unique id per client.
I need send private messages.

Answering my own question:

The way I managed to identify the clients was this

ws._ultron.id

[Josephine7]

Hey @projetoarduino
So I am following your train of thought. I also needed unique identifiers for our customers. How did you then send that message to a particular user ?

[projetoarduino]

Hi use wss.clients.forEach but add one 'if' to compare and send only client you need.
You need create one object to store ws._ultron.id and associated to another data you know, one nick or Id

function senMess(get_dest, message){ wss.clients.forEach(function each(client) { console.log(client); if (client !== ws && client.readyState === WebSocket.OPEN && client.ws._ultron.id == CLIENTS[get_dest]) { client.send(message); } });

[lpinca]

Don't use private properties as they may disappear at any time. If you need a unique id per connection generate it.

wss.on('connection', (ws) => {
  ws.id = uuid();
});

[projetoarduino]

@lpinca Thanks, i tested this and work fine.