-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a quiet mode #86
base: master
Are you sure you want to change the base?
Conversation
incoming pings will be silenced from console if option --quiet is used
Added examples on how to use the --slash and --quiet flags and what they will do.
Thank you for the PR. Some thoughts:
|
At the same time wouldn't hurt to have, but should not be under the same flag. I am testing a service that will ping often and I don't need to know, just pong back, but when I ping I want to ensure it pongs me.
|
My point is, if this happens with everything that is written (data messages, pings, pongs) why this only take into account pings? Not sure if it's possible or how hard it will be but isn't it better to try to solve the issue differently? Ideally what is written should not mess up user input. |
Perhaps a slightly different view of the same problem. To me, ping/pongs are part of the underlying protocol. In the same way I don't see the HTTP upgrade request, I don't want to see the websocket control frames in normal operation. Based on that, perhaps another option for verbose control frames? By default, no control frames are printed but Does that make sense? |
I was testing a service that pinged a lot, and would interrupt typing, so I added a flag
-q, --quiet
that would silence the ping control frame (pong and close control frames handled same as usual) from the console.May be useful for others 🤷♂️ 😄