Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preview Interactions Bug #1824

Closed
markxtang opened this issue Jun 20, 2023 · 0 comments · Fixed by #1861
Closed

Preview Interactions Bug #1824

markxtang opened this issue Jun 20, 2023 · 0 comments · Fixed by #1861
Assignees
@istarkov
Labels
prio:1 The most important thing to work on type:bug Something isn't working

Comments

@markxtang
Copy link
Contributor

Links to page sections don't currently work in preview mode.
Forms aren't currently fillable in preview mode either. It should be possible to fill a form in preview mode, but not to send it.

Preview.Interactions.Bug.mp4
@markxtang markxtang added area:builder type:bug Something isn't working prio:1 The most important thing to work on labels Jun 20, 2023
@kof kof assigned istarkov and unassigned kof Jun 20, 2023
@istarkov istarkov mentioned this issue Jun 26, 2023
Merged
10 tasks
istarkov added a commit that referenced this issue Jun 28, 2023
@istarkov @kof
Fix hash scroll (#1861)
7632b05 
## Description

closes #1824

- [x] single edgecase left if id is equal to `hello%20world` nothing
works
- [x] fix back button cause chrome bug
https://discord.com/channels/955905230107738152/1122839004375691355
- [x] allow edit form in preview mode to close issue above

Fix corresponding issue in RR
remix-run/react-router#10642

At SaaS patched too

## Steps for reproduction

create links on pages with anchor
<img width="254" alt="image"
src="https://github.com/webstudio-is/webstudio-builder/assets/5077042/46a880f3-cdd0-4e19-8cb4-b608bdc4f96a">

Check it works

## Code Review

- [ ] hi @kof, I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
5de6)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio-builder/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env.example`
and the `builder/env-check.js` if mandatory

---------

Co-authored-by: Oleg Isonen <oleg008@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@istarkov istarkov

Labels
prio:1 The most important thing to work on type:bug Something isn't working
Projects
No open projects
Webstudio Components
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix hash scroll webstudio-is/webstudio
3 participants
@kof @istarkov @markxtang