Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Сombobox if the menu is opened using the up or down arrows, we want to display all items without applying any filters #4311

Merged
merged 2 commits into from
Oct 19, 2024

Conversation

istarkov
Copy link
Member

Description

  1. What is this PR about (link the issue and add a short description)

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

Copy link
Member

@kof kof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested looking good

@kof
Copy link
Member

kof commented Oct 19, 2024

please add a commment above that logic

@istarkov istarkov changed the title fix: Fix combobox down-up fix: Сombobox if the menu is opened using the up or down arrows, we want to display all items without applying any filters Oct 19, 2024
@istarkov istarkov merged commit c9ce12c into main Oct 19, 2024
17 checks passed
@istarkov istarkov deleted the fix-down-up branch October 19, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants