Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Block editing with arrow keys #4334

Merged
merged 19 commits into from
Oct 28, 2024
Merged

feat: Block editing with arrow keys #4334

merged 19 commits into from
Oct 28, 2024

Conversation

istarkov
Copy link
Member

@istarkov istarkov commented Oct 22, 2024 •
edited
Loading

Description

  • Double click now sets cursor to the click position
  • Up/Down arrows on a first/last line trying to preserve cursor x position (visible in case of block above block)
  • Right/Left arrows switch blocks if cursor is at block begin/end.

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@istarkov
Add editing
2a97b41 
Prevent nav

Fix detection

Fix

Add reason

Set cursor at click position

Remove lazy loading

Add defaults

Switch on args

Add 2 editors story

Cursor up down

Fix a and button editing

Fix

Fix jumping issues

Fix detection

Fix

Add css

Less updates

Do not patch on same state

Fix ff and sasfari

Fix
@istarkov istarkov changed the title chore: Notion like edit feat: Block editing with arrow keys Oct 28, 2024
@istarkov istarkov marked this pull request as ready for review October 28, 2024 08:41
@istarkov istarkov requested review from TrySound and kof October 28, 2024 08:44
TrySound
TrySound approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@TrySound TrySound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant

@istarkov istarkov merged commit afc77fa into main Oct 28, 2024
15 checks passed
@istarkov istarkov deleted the edit branch October 28, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TrySound TrySound TrySound approved these changes

@kof kof Awaiting requested review from kof

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@istarkov @TrySound