Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove legacy style engine from style panel #4338

Merged
merged 1 commit into from
Nov 4, 2024
Merged

refactor: remove legacy style engine from style panel #4338

merged 1 commit into from
Nov 4, 2024

Conversation

TrySound
Copy link
Member

Migrated style panel to new style engine for sections rendering and switched position section as well.

Test following cases

  • flex child section when parent has flex
  • list style section for list or list item
  • inset control when position value is relative, absolute, fixed or sticky
  • inset control when position is inherited form relative etc
  • zindex control when parent is flex or grid

@TrySound TrySound requested review from kof and istarkov October 24, 2024 14:23
@TrySound
refactor: remove legacy style engine from style panel
a3fe0e9 
Migrated style panel to new style engine for sections rendering
and switched position section as well.
@johnsicili johnsicili self-requested a review November 3, 2024 20:37
@TrySound TrySound merged commit 4fb2338 into main Nov 4, 2024
15 checks passed
@TrySound TrySound deleted the style-panel branch November 4, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnsicili johnsicili johnsicili approved these changes

@istarkov istarkov istarkov approved these changes

@kof kof Awaiting requested review from kof

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TrySound @istarkov @johnsicili