Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add SaaS template to trpc #4445

Merged
merged 1 commit into from
Nov 19, 2024
Merged

chore: Add SaaS template to trpc #4445

merged 1 commit into from
Nov 19, 2024

Conversation

johnsicili
Copy link
Contributor

Adding new template to the dashboard. Getting this queued up and will coordinate with someone to add to .env, though it's okay if this goes out first.

SaaS Landing
5b33acf4-53cf-4f03-8973-d5679772edee

Description

  1. What is this PR about (link the issue and add a short description)

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 0000)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

Adding new template to the dashboard. Getting this queued up and will coordinate with someone to add to .env, though it's okay if this goes out first.

SaaS Landing
5b33acf4-53cf-4f03-8973-d5679772edee
@johnsicili johnsicili requested a review from istarkov November 19, 2024 17:09
@kof kof merged commit 1fd98a2 into main Nov 19, 2024
15 checks passed
@kof kof deleted the saastemplate branch November 19, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants