Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make loading screen background dark #4449

Merged
merged 5 commits into from
Nov 21, 2024
Merged

feat: make loading screen background dark #4449

merged 5 commits into from
Nov 21, 2024

Conversation

kof
Copy link
Member

@kof kof commented Nov 20, 2024

Description

A better looking loading screen

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 0000)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@kof kof requested review from johnsicili and istarkov November 20, 2024 00:18
@johnsicili
Copy link
Contributor

Is there a way to combat this white screen? Even if its just setting the default color to the same of the loader, that will look better. White screen with nothing seems like there is some issue.

loader.mp4

@kof
Copy link
Member Author

kof commented Nov 20, 2024

Good idea actually

@kof
Copy link
Member Author

kof commented Nov 20, 2024

done, check it out

@johnsicili
Copy link
Contributor

Looks better. I don't know if its related to this PR, but when I access a Project via a share link, the loading screen doesn't go away

@kof
Copy link
Member Author

kof commented Nov 20, 2024

reverted back the fix I was trying to make in parallel to the background change, which is about waiting for selected instance, before closing the overlay, currently its still having some movement after its loaded I wanted to avoid for a better effect, but seems too hard

@johnsicili good catch with this one

@kof kof merged commit eaf39c5 into main Nov 21, 2024
13 of 15 checks passed
@kof kof deleted the dark-splash branch November 21, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants