Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

experimental: Content mode icon and a new preview mode icon #4473

Merged
merged 2 commits into from
Nov 26, 2024
Merged

experimental: Content mode icon and a new preview mode icon #4473

merged 2 commits into from
Nov 26, 2024

Conversation

kof
Copy link
Member

@kof kof commented Nov 25, 2024

Description

  1. What is this PR about (link the issue and add a short description)

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 0000)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@kof kof requested a review from istarkov November 25, 2024 20:39
@kof kof merged commit 8c83b67 into main Nov 26, 2024
15 checks passed
@kof kof deleted the content-icon branch November 26, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TrySound TrySound TrySound approved these changes

@istarkov istarkov Awaiting requested review from istarkov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kof @TrySound