Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Collapsed state was incorrectly calculated in some cases. #4492

Merged
merged 2 commits into from
Dec 1, 2024

Conversation

istarkov
Copy link
Member

@istarkov istarkov commented Dec 1, 2024

Description

ref #3994

2 bugs:

  1. Wrong calculation of
Box
  Box display=contents
     Box

Example before this PR

https://p-882ed593-40cc-4382-b119-15c588d0ce6f-dot-main.development.webstudio.is/

image

Example After this PR
https://p-882ed593-40cc-4382-b119-15c588d0ce6f-dot-fix-collapse.development.webstudio.is/

image
  1. It was possible that Content Block was like
Box contents
  Box contents

what caused inability to find it position, outline and collapse attributes

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 0000)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@istarkov istarkov mentioned this pull request Dec 1, 2024
58 tasks
@istarkov istarkov merged commit 93fc476 into main Dec 1, 2024
17 checks passed
@istarkov istarkov deleted the fix-collapse branch December 1, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants