Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

experimental: Set the menu items height along with the content mode shortcut and name #4494

Merged
merged 1 commit into from
Dec 2, 2024
Merged

experimental: Set the menu items height along with the content mode shortcut and name #4494

merged 1 commit into from
Dec 2, 2024

Conversation

kof
Copy link
Member

@kof kof commented Dec 2, 2024

Description

  • 24px height for menu items
  • drive-by: content mode + shortcut cmd+c

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 0000)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@kof kof requested a review from istarkov December 2, 2024 14:44
@kof kof merged commit 69fd855 into main Dec 2, 2024
15 checks passed
@kof kof deleted the menu-items-height2 branch December 2, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TrySound TrySound TrySound approved these changes

@istarkov istarkov istarkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kof @istarkov @TrySound