Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make empty style panel sections easier to recognize as empty #4497

Merged
merged 10 commits into from
Dec 4, 2024

Conversation

kof
Copy link
Member

@kof kof commented Dec 3, 2024

Description

  1. Its easier to scan the panel when titles are dimmed if there is nothing in the content of that section
  2. when section has nothing it shouldn't have a chevron on hover
image image

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 0000)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@kof kof requested review from TrySound and johnsicili December 3, 2024 00:18
@kof kof merged commit f395bbe into main Dec 4, 2024
15 checks passed
@kof kof deleted the inactive-label branch December 4, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants