Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Auto scroll CSS Value inputs when value is too long just by hovering with the mouse #4502

Merged
merged 6 commits into from
Dec 4, 2024

Conversation

kof
Copy link
Member

@kof kof commented Dec 3, 2024

Description

  1. When not focused will scroll
  2. Only active on fields with scroll potential

https://share.descript.com/view/x0E72z2aFlS

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 0000)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@kof kof requested a review from johnsicili December 3, 2024 18:39
@johnsicili
Copy link
Contributor

@kof no feature flag?

@kof kof requested a review from TrySound December 4, 2024 12:11
@kof kof marked this pull request as ready for review December 4, 2024 15:24
@kof
Copy link
Member Author

kof commented Dec 4, 2024

@johnsicili updated:

  1. only active on fields that have potential to get scrolling
  2. only while field is not focused

I think its realtively low risk, going live without feature flag with this one

@kof kof merged commit c57d308 into main Dec 4, 2024
15 checks passed
@kof kof deleted the auto-scroll branch December 4, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants