Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent focus when selecting form label in builder #4516

Merged
merged 2 commits into from
Dec 5, 2024
Merged

fix: Prevent focus when selecting form label in builder #4516

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2837ea7
fix: Prevent focus when selecting form label in builder
istarkov Dec 5, 2024
a4b84e6
Switch on single if
istarkov Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions apps/builder/app/canvas/interceptor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,15 @@ const switchPageAndUpdateSystem = (href: string, formData?: FormData) => {

export const subscribeInterceptedEvents = () => {
const handleClick = (event: MouseEvent) => {
// Prevent forwarding the click event on an input element when the associated label has a "for" attribute
if (
event.target instanceof Element &&
event.target.closest("label[for]") &&
!$isPreviewMode.get()
) {
event.preventDefault();
}

if (
event.target instanceof HTMLElement ||
event.target instanceof SVGElement
Expand Down
Loading