replace deprecated new Buffer()
#71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhermsmeier
approved these changes
Apr 21, 2017
There was a problem hiding this comment.
Looks good to me, although I personally don't like how and why new Buffer() was deprecated – but we'll have to switch sooner or later anyways. @themasch, thoughts?
I think this was the issue that prompted it: nodejs/node#4660 |
notslang
force-pushed
the
remove-new-buffer
branch
from
8c17eb9
to
6fcd0af
Compare
|
Compared master to this PR and it really seems to be slightly faster. Thanks again @slang800! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...with
Buffer.from()&Buffer.allocUnsafe()