Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify ENUM names #110

Closed
huan opened this issue Feb 19, 2021 · 1 comment
Closed

Simplify ENUM names #110

huan opened this issue Feb 19, 2021 · 1 comment
Labels
wontfix This will not be worked on

Comments

@huan
Copy link
Member

huan commented Feb 19, 2021

MESSAGE_TYPE_IMAGE -> IMAGE

See: https://cloud.google.com/apis/design/design_patterns#enum_default_value
@huan huan added the breaking Breaking changes label Feb 19, 2021
@huan
Copy link
Member Author

huan commented Sep 22, 2021 •
edited
Loading

This can not be implemented due to the limitation of the gRPC itself does not permit.

See:

.NET has a nice feature to rename all of them when running the generator (Protobuf enumerations), don't know if javascript has any similar tools.

@huan huan added wontfix This will not be worked on and removed breaking Breaking changes labels Sep 22, 2021
@huan huan closed this as completed Sep 22, 2021
huan added a commit that referenced this issue Sep 22, 2021
@huan
restore long name for enum (#110)
f050372
huan added a commit that referenced this issue Oct 3, 2021
@huan
Refactoring gRPC & OpenAPI (#150)
890734f 
* refactoring openapi wip

* 0.29.1

* timestamp -> receive_time_millis

* clean enum NAMES

* use google.protobuf.Timestamp

* deprecated comment

* deprecate & uint32 -> int32

* clean

* restore long name for enum (#110)

* clean

* import timestamp

* 0.29.23

* add _deprecated postfix

* 0.29.24

* clean

* 0.29.25

* clean

* 0.29.26

* clean

* 0.29.27

* clean

* 0.29.28

* clean

* 0.29.29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@huan