Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #201

Merged
merged 4 commits into from
Jul 27, 2023
Merged

Fix CI #201

merged 4 commits into from
Jul 27, 2023

Conversation

hcfw007
Copy link
Member

@hcfw007 hcfw007 commented Jul 18, 2023

I checked the log of the last failed actions.

image

For C#, it failed to locate the google api proto files, so I renamed the files.

image

For Node, it failed for the same reason I explained in wechaty issue (wechaty/wechaty#2551)

image

For PHP, it failed when checking protoc version. This is a bug of version check script. So I fixed it.

@hcfw007 hcfw007 requested a review from Jesn as a code owner July 19, 2023 09:10
@hcfw007
Copy link
Member Author

hcfw007 commented Jul 19, 2023

@huan I believe I have fixed CI for PHP Node and C# (So all CI should pass now!), but somehow it won't trigger the pack process.

@hcfw007 hcfw007 changed the title [WIP] Fix CI Fix CI Jul 19, 2023
windmemory
windmemory previously approved these changes Jul 27, 2023
Copy link
Member

@windmemory windmemory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huan
Copy link
Member

huan commented Jul 27, 2023

Can you explain the modifications in the PR description? Because I want to understand what I will merge.

After that, the PR will be good to be merged.

@hcfw007
Copy link
Member Author

hcfw007 commented Jul 27, 2023

Can you explain the modifications in the PR description? Because I want to understand what I will merge.

After that, the PR will be good to be merged.

@huan Sure and done.

Copy link
Member

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you very much for the fix!

@huan huan merged commit f1ecd6c into wechaty:main Jul 27, 2023
1 check passed
@huan huan deleted the fix/ci-and-lint branch July 27, 2023 07:24
@hcfw007
Copy link
Member Author

hcfw007 commented Jul 27, 2023

Seems there are still some CI issue after this PR merged.
The C# CI was good in the PR (https://github.com/wechaty/grpc/actions/runs/5676969240), but somehow failed now.
The Node CI failed for Unknown compiler option 'verbatimModuleSyntax'. Maybe TS version was locked by onf of the dependencies.
I'll look into them.

The Golang CI failed for acess right issue, maybe you can give it a look? @huan
image

By the way, any idea of the reason Pack CI not triggered in PR?

@hcfw007 hcfw007 mentioned this pull request Jul 30, 2023
@huan
Copy link
Member

huan commented Aug 7, 2023

By the way, any idea of the reason Pack CI was not triggered in PR?

I think it's related to the bug in GitHub Actions.

Can you push a new commit to trigger it again to see if it works now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants