-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI #201
Fix CI #201
Conversation
@huan I believe I have fixed CI for PHP Node and C# (So all CI should pass now!), but somehow it won't trigger the pack process. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Can you explain the modifications in the PR description? Because I want to understand what I will merge. After that, the PR will be good to be merged. |
@huan Sure and done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you very much for the fix!
Seems there are still some CI issue after this PR merged. The Golang CI failed for acess right issue, maybe you can give it a look? @huan By the way, any idea of the reason Pack CI not triggered in PR? |
I think it's related to the bug in GitHub Actions. Can you push a new commit to trigger it again to see if it works now? |
I checked the log of the last failed actions.
For C#, it failed to locate the google api proto files, so I renamed the files.
For Node, it failed for the same reason I explained in wechaty issue (wechaty/wechaty#2551)
For PHP, it failed when checking protoc version. This is a bug of version check script. So I fixed it.