Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for cnpm's change. #64

Merged
merged 1 commit into from
Jan 5, 2019
Merged

Update for cnpm's change. #64

merged 1 commit into from
Jan 5, 2019

Conversation

solarhell
Copy link
Contributor

Update for cnpm's change.

Update for cnpm's change.
@huan
Copy link
Member

huan commented Jan 4, 2019

Thanks for the contribution!

Could you please file an issue related to this PR and describe the details about why we need this change?

And please get at least one approvement from our contributes before I could be able to merge this PR.

@solarhell
Copy link
Contributor Author

solarhell commented Jan 4, 2019

see cnpm/cnpmjs.org#1246 (comment)

Need to change the readme for the old mirror is deprecated.

@huan
Copy link
Member

huan commented Jan 4, 2019

@solarhell Thanks for the link, it's very useful.

I'll merge this PR after it gets an approvement from our contributors, thank you very much!

@huan huan requested a review from a team January 5, 2019 04:13
Copy link
Member

@windmemory windmemory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the contribution.

@huan huan merged commit 0b1b5ea into wechaty:master Jan 5, 2019
@huan
Copy link
Member

huan commented Jan 5, 2019

@windmemory Thanks for the approvement, merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants