Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ Refactor DatashaderRasterizer to be up front about datapipe lengths #39

Merged
merged 1 commit into from
Aug 19, 2022
Merged

♻️ Refactor DatashaderRasterizer to be up front about datapipe lengths #39

merged 1 commit into from
Aug 19, 2022

Commits on Aug 19, 2022

  1. ♻️ Refactor DatashaderRasterizer to be up front about dp lengths 

    Check during initialization of DatashaderRasterizerIterDataPipe on whether the input canvas and vector datapipes have compatible lengths. This is better than finding out that the zip function doesn't work when the datapipe is being iterated over. Added a unit test to cover the 3:2 ratio case and documented why the ValueError is raised on unmatched lengths. Also renamed the previous ValueError on unsupported geometry types to NotImplementedError to avoid confusion.
    @weiji14
    weiji14 committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    b7d593f View commit details
    Browse the repository at this point in the history