Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applies the magic 1 combat mastery to always max hit NPCs #572

Closed

Conversation

coopermor
Copy link
Contributor

The magic 1 combat mastery is not applies to NPCs that are always max hit (like the fremennik warband berserker). Example here: https://dps.osrs.wiki?id=TaintedSlicesKasa

@LlemonDuck
Copy link
Collaborator

do you have confirmation this is applied? we were intentionally working under the assumption that it does NOT apply prior to the damage roll, and therefore wouldn't work here

@coopermor
Copy link
Contributor Author

I have not seen confirmation one way or another. I just assumed based on the description 'When you roll above 90% of your max hit with Magic, damage is increased by 50%.'

I think your interpretation does make sense considering there isn't really a roll. I guess we can wait until there is confirmation one way or another or it is tested in leagues.

@LlemonDuck
Copy link
Collaborator

we got confirmation that it applies to all npcs even for t6 one hits so i've applied it as such in 3177875

@LlemonDuck LlemonDuck closed this Nov 26, 2024
@coopermor
Copy link
Contributor Author

Unless I am misunderstanding your comment 3177875 is not implemented properly.

else if ((this.player.style.type === 'magic' && ALWAYS_MAX_HIT_MONSTERS.magic.includes(this.monster.id))
      || (this.isUsingMeleeStyle() && ALWAYS_MAX_HIT_MONSTERS.melee.includes(this.monster.id))
      || (this.player.style.type === 'ranged' && ALWAYS_MAX_HIT_MONSTERS.ranged.includes(this.monster.id))) {
      // monsters that are always max hit no matter what
      return new AttackDistribution([HitDistribution.single(1.0, [new Hitsplat(max)])]);
    }

Reference the example of Magic 0 vs Magic 1 where both have a max hit of 31. I believe the max hit should be increased to 46 with the Magic 1 mastery.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants