fix - for publish to pub.dev, remove ios frameworks and android aar files #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hhstore
changed the title
| // https://github.com/trustwallet/wallet-core | ||
| // https://mvnrepository.com/artifact/com.trustwallet/wallet-core | ||
| // implementation(name: 'trustwalletcore', ext: 'aar') | ||
| implementation group: 'com.trustwallet', name: 'wallet-core', version: '2.6.3' // use this, has running errors |
There was a problem hiding this comment.
official aar are not compatible for this project, it will throw exception with function not found. and official version 2.6.3 is too old, There are many API breaking change in master branch.
There was a problem hiding this comment.
yes, it will throw exception with function not found.
there seems to be a lot of work to be done. perhaps, the official team needs to work together to solve these problems.
|
As official lib is build with CMAKE_CXX_VISIBILITY_PRESET = hidden, function is not lookup-able for dart, close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update:
Frameworks/*.xcframework, the package size will be <50MB(Android aar file = 10 MB), then it should be able to publish to pub.dev. 😄iOS:
Frameworks/*.xcframeworkby podAndroid:
implementation group: 'com.trustwallet', name: 'wallet-core', version: '2.6.3'replaceimplementation(name: 'trustwalletcore', ext: 'aar'), the example compiles fine, but runs with some errors, here: