Merge pull request #10 from weiwei04/compass-dev

offset -> Start
weiwei04 · Aug 17, 2017 · 40e6457 · 40e6457
2 parents 778a821 + 0df33f0
commit 40e6457
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/pkg/api/client/registry.go b/pkg/api/client/registry.go
@@ -68,10 +68,10 @@ type ListChartsResponse struct {
 //}
 
 type ListChartVersionsRequest struct {
-	Space  string
-	Chart  string
-	Limit  int
-	offset int
+	Space string
+	Chart string
+	Limit int
+	Start int
 }
 
 type ListChartVersionsResponse struct {

diff --git a/pkg/api/client/registry_impl.go b/pkg/api/client/registry_impl.go
@@ -84,17 +84,17 @@ func (r *helmRegistry) ListCharts(ctx context.Context, req *ListChartsRequest) (
 
 // 列取mysapce/mychart的所有版本
 func (r *helmRegistry) ListChartVersions(ctx context.Context, req *ListChartVersionsRequest) (*ListChartVersionsResponse, error) {
-	listResp, err := r.client.ListVersions(req.Space, req.Chart, req.offset, req.Limit)
+	listResp, err := r.client.ListVersions(req.Space, req.Chart, req.Start, req.Limit)
 	if err != nil {
 		return nil, err
 	}
 
 	return &ListChartVersionsResponse{
 		Versions: listResp.Items,
-		IsEnd:    req.offset+len(listResp.Items) >= listResp.Metadata.Total,
+		IsEnd:    req.Start+len(listResp.Items) >= listResp.Metadata.Total,
 		space:    req.Space,
 		chart:    req.Chart,
-		offset:   req.offset,
+		offset:   req.Start,
 		limit:    req.Limit,
 	}, nil
 }