mkksiso: option --replace to replace arbitrary text in boot config. #1402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- It is a generalized version of the code that replaces the volume ID.
- Test adjusted accordingly because signature changed slightly.
- This can be used to augment/change the user visible boot menu to add
more information about the kickstart installation that is going to
happen.
- Implemented for grub and isolinux, not s390 (don't know how to
test).
|
Thanks, this looks pretty good, but please also update it for S390 and don't worry about testing -- the volid change should be enough and the signature for the functions needs to be consistent. |
|
I added a commit on top for that, let me know if you would rather have that squashed into one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a generalized version of the code that replaces the volume ID.
Test adjusted accordingly because signature changed slightly.
This can be used to augment/change the user visible boot menu to add more information about the kickstart installation that is going to happen.
Implemented for grub and isolinux, not s390 (don't know how to test).