Port erofs root fs compression code to RHEL10 #1412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstodola
reviewed
Jul 17, 2024
Related: RHEL-48606
The cmdline switch, --squashfs-only, now sets this and the new --rootfs-type can be used to select other rootfs types. Currently only squashfs and squashfs-ext4 are actually implemented. This also changes the default to a plain squashfs without the wrapped ext4 image. This speeds up image creation and there is no longer a reason to use the wrapped ext4 method. Related: RHEL-48606
Passing 'erofs' will create a plain erofs compressed image. Passing 'erofs-ext4' will create a LiveOS/rootfs.img ext4 filesystem compressed by erofs. Related: RHEL-48606
Set the default compression style to lzma and use the config values when creating the erofs compressed rootfs. Resolves: RHEL-48606
[bcl - edited for brevity] It seems safer, to me, to accept --squashfs-only but simply ignore it (since the default value of --rootfs-type is squashfs anyway, and if someone were to specify both, I think it's sane for --rootfs-type to 'win'). Related: RHEL-48606 Signed-off-by: Adam Williamson <awilliam@redhat.com> Signed-off-by: Brian C. Lane <bcl@redhat.com>
It works either way, but this is easier to read in the logs and matches the manpage. Related: RHEL-48606
These produce smaller images, at the expense of time. You can change the options used by passing a lorax.conf file that looks like this, eg. use 64k cluster size along with the dedupe and all-fragment options: [compression.erofs] type = lz4 args = -E dedupe,all-fragments -C 65536 And run with: lorax -c ./lorax.conf --rootfs-type erofs ... Related: RHEL-48606
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.