Remove old RDS database (#2733)

* remove old rds * remove tei database and unused module
wellcomecollection · Oct 18, 2024 · 88d3ebe · 88d3ebe
1 parent 3b31c61
commit 88d3ebe
Show file tree

Hide file tree

Showing 8 changed files with 2 additions and 107 deletions.
diff --git a/infrastructure/critical/modules/rds-serverless/variables.tf b/infrastructure/critical/modules/rds-serverless/variables.tf
@@ -1,5 +1,6 @@
 variable "cluster_identifier" {
-  type = string
+  type    = string
+  default = null
 }
 
 variable "database_name" {

diff --git a/infrastructure/critical/modules/rds/main.tf b/infrastructure/critical/modules/rds/main.tf
diff --git a/infrastructure/critical/modules/rds/outputs.tf b/infrastructure/critical/modules/rds/outputs.tf
diff --git a/infrastructure/critical/modules/rds/secrets.tf b/infrastructure/critical/modules/rds/secrets.tf
diff --git a/infrastructure/critical/modules/rds/variables.tf b/infrastructure/critical/modules/rds/variables.tf
diff --git a/infrastructure/critical/outputs.tf b/infrastructure/critical/outputs.tf
@@ -1,9 +1,5 @@
 # RDS
 
-output "rds_cluster_id" {
-  value = module.identifiers_delta_rds_cluster.rds_cluster_id
-}
-
 output "rds_serverless_cluster_id" {
   value = module.identifiers_serverless_rds_cluster.rds_cluster_id
 }

diff --git a/infrastructure/critical/rds_id_minter.tf b/infrastructure/critical/rds_id_minter.tf
@@ -46,25 +46,6 @@ resource "aws_security_group" "database_sg" {
   }
 }
 
-module "identifiers_delta_rds_cluster" {
-  source             = "./modules/rds"
-  cluster_identifier = "identifiers-delta-cluster"
-  database_name      = "identifiers"
-  username           = local.rds_username
-  password           = local.rds_password
-
-  # This instance class provides us with 45 connections per instance.
-  instance_count = 1
-  instance_class = "db.t3.medium"
-
-  db_security_group_id     = aws_security_group.database_sg.id
-  aws_db_subnet_group_name = aws_db_subnet_group.default.name
-
-  engine                  = "aurora-mysql"
-  db_parameter_group_name = "default.aurora-mysql5.7"
-}
-
-# This is the serverless RDS cluster that we will migrate to.
 module "identifiers_serverless_rds_cluster" {
   source = "./modules/rds-serverless"
 
@@ -76,7 +57,6 @@ module "identifiers_serverless_rds_cluster" {
   db_security_group_id     = aws_security_group.database_sg.id
   aws_db_subnet_group_name = aws_db_subnet_group.default.name
 
-  # This is the snapshot from the last time we migrated the database.
   snapshot_identifier = "aurora-mysql-v3-pre-migration-24-10-08"
 
   engine_version = "8.0.mysql_aurora.3.07.1"

diff --git a/tei_adapter/terraform/rds_id_extractor.tf b/tei_adapter/terraform/rds_id_extractor.tf
@@ -46,24 +46,6 @@ resource "aws_security_group" "database_sg" {
   }
 }
 
-module "tei_id_extractor_rds_cluster" {
-  source             = "../../infrastructure/critical/modules/rds"
-  cluster_identifier = "tei-adapter-cluster"
-  database_name      = "pathid"
-  username           = local.rds_username
-  password           = local.rds_password
-
-  # This instance class provides us with 45 connections per instance.
-  instance_count = 1
-  instance_class = "db.t3.small"
-
-  db_security_group_id     = aws_security_group.database_sg.id
-  aws_db_subnet_group_name = aws_db_subnet_group.default.name
-
-  engine                  = "aurora-mysql"
-  db_parameter_group_name = aws_db_parameter_group.default.id
-}
-
 module "tei_id_extractor_rds_serverless_cluster" {
   source             = "../../infrastructure/critical/modules/rds-serverless"
   cluster_identifier = "tei-adapter-cluster-serverless"