Marc alternative titles #2598
Merged
Marc alternative titles #2598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…co/pipeline/transformer/marc_common/transformers/MarcElectronicResourcesTest.scala Co-authored-by: Robert Kenny <kenoir@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Part of #2563
Moves Sierra Alternative Titles to the common Marc Alternative Titles
Have we considered potential risks?
There's a small part of this that is kinda Sierra-specific, (the UkLW stuff), but it would only be problematic in a very unlikely scenario:
Even in that scenario, it's not a significant problem, and we'd simply have to create a source-specific transformer for that field, which is what I'm not bothering to do now in mitigation.