Send the Scala dependency graph #2600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamieparkinson
approved these changes
Mar 22, 2024
| @@ -348,7 +348,7 @@ lazy val tei_adapter = setupProject( | |||
| s3CredentialsProvider := { | |||
| _ => | |||
| val builder = new STSAssumeRoleSessionCredentialsProvider.Builder( | |||
| "arn:aws:iam::760097843905:role/platform-ci", | |||
| "arn:aws:iam::760097843905:role/terraform-20210811133135108800000001", | |||
There was a problem hiding this comment.
obviously not for this PR but is there a way of giving this role a nicer name?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Follows wellcomecollection/catalogue-api#766 this change pushes the scala dependency graph to the GitHub API to surface vulnerabilities.
We don't need access to S3 as with other similar pull requests as we're not pulling our own deps (we build them here).
Part of wellcomecollection/platform-infrastructure#431
Depends on wellcomecollection/aws-account-infrastructure#19
How to test
How can we measure success?
Visibility on dependencies and vulnerabilities.
Have we considered potential risks?
This change should help manage / reduce risk.