2268 only disallow certain magic attributes

[ariebovenberg]

I have made things!

See #2268

Checklist

• I have double checked that there are no unrelated changes in this pull request (old patches, accidental config files, etc)
• I have created at least one test case for the changes I have made
• I have updated the documentation for the changes I have made
• I have added my changes to the CHANGELOG.md

Related issues

Closes #2268

[sobolevn]

Let's move this to constants.py, it is rather long!

It would also be a good idea to link to it from the violation's docs.

Thanks a lot for your time and effort 👍

[codecov]

Codecov Report

Merging #2281 (5388faf) into master (0e34852) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 5388faf differs from pull request most recent head bda482a. Consider uploading reports for the commit bda482a to get more accurate results

@@            Coverage Diff            @@
##            master     #2281   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          119       119           
  Lines         6316      6316           
  Branches      1409      1409           
=========================================
  Hits          6316      6316           

Impacted Files	Coverage Δ
wemake_python_styleguide/constants.py	100.00% <ø> (ø)
wemake_python_styleguide/violations/oop.py	100.00% <ø> (ø)
...emake_python_styleguide/visitors/ast/attributes.py	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e34852...bda482a. Read the comment docs.

[ariebovenberg]

@sobolevn note I added some missing magic methods (like __next__) to the already existing ALL_MAGIC_METHODS constant. This may affect other violations (in a good way -- it's more complete now). Do we want to mention this as a fix in the changelog as well?

[sobolevn]

Do we want to mention this as a fix in the changelog as well?

Yes, please! 👍

I've also added attrs magic methods, because they are special enough to cover 🙂

[ariebovenberg]

Added the changelog entry. I set this PR as a ref since this is where we discussed the fix.

[sobolevn]

Thanks again!