Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #2577 #2594

Merged
merged 6 commits into from
Mar 21, 2023
Merged

Fixed #2577 #2594

merged 6 commits into from
Mar 21, 2023

Conversation

Roxe322
Copy link
Contributor

@Roxe322 Roxe322 commented Mar 21, 2023

I have made things!

Checklist

  • I have double checked that there are no unrelated changes in this pull request (old patches, accidental config files, etc)
  • I have created at least one test case for the changes I have made
  • I have updated the documentation for the changes I have made
  • I have added my changes to the CHANGELOG.md

Related issues

🙏 Please, if you or your company is finding wemake-python-styleguide valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/wemake-python-styleguide. As a thank you, your profile/company logo will be added to our main README which receives hundreds of unique visitors per day.

@Roxe322
Copy link
Contributor Author

Roxe322 commented Mar 21, 2023

Hi @sobolevn! I see some issues with GHA, even in other PRs, so I didn't fix them, but very glad to fix some small issue mentioned in this PR.
On my local machine same tests (test_formatter) are down while running on a code without any changes

@sobolevn
Copy link
Member

Do you have time to see what's wrong with the GH? I can merge this PR later :)

@sobolevn
Copy link
Member

You probably need to update snapshots with pytest tests/test_checker --snapshot-update (or something similar)

@sobolevn
Copy link
Member

You can just drop safety completely :)
No need to fix it. See #2569

@sobolevn
Copy link
Member

Thank you very much! 👍
Great work!

I really appreciate your help with the CI.

@sobolevn sobolevn merged commit 4cb5a65 into wemake-services:master Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive on WPS515
2 participants