Fix ckpt conversion bug #2399
Merged
Fix ckpt conversion bug #2399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhr1201
commented
Mar 11, 2024
| default="", | ||
| type=str, | ||
| help='dict of name adder, e.g."{\"key1\": \"value1\"}"') | ||
| parser.add_argument( |
There was a problem hiding this comment.
yapf was complaining
zhr1201
commented
Mar 11, 2024
| @@ -39,18 +41,22 @@ def main(): | |||
|
|
|||
| state = torch.load(args.input_ckpt, map_location="cpu") | |||
| new_state = {} | |||
|
|
|||
| if args.remove_list: | |||
There was a problem hiding this comment.
it skips cloning the weight if remove_list is empty
zhr1201
commented
Mar 11, 2024
wenet/transformer/search.py
Outdated
| @@ -175,7 +175,7 @@ def ctc_prefix_beam_search( | |||
| next_score1.ns = log_add(next_score1.ns, | |||
| prefix_score.ns + prob) | |||
| if next_score1.v_ns < prefix_score.v_ns + prob: | |||
| next_score1.vs_ns = prefix_score.v_ns + prob | |||
| next_score1.v_ns = prefix_score.v_ns + prob | |||
|
there seems to be a clang format version mismatch in pre commit hook and github workflow |
|
|
pulled in the version fix from main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug was introduced in #2381, basically it will skip copying all the weight if remove_list is empty.