Add option to search ahead of the cursor #10
Conversation
|
thanks for the contribution, the idea is good, will review next week . |
| for (let i = 0; i < doc.lineCount; i++) { | ||
| const matches = _searchLine(i, doc.lineAt(i).text, parsed) | ||
| const lineIndex = (startLine + i) % doc.lineCount; | ||
| const matches = _searchLine(lineIndex, doc.lineAt(lineIndex).text, parsed) |
There was a problem hiding this comment.
so the list of matches become smaller and smaller as user go down to the file?
i prefer the behavior the matched list stay constant, but the pick.activeItems changes based on the current position of the cursor.
thoughts?
There was a problem hiding this comment.
Hmm, you're right - that's a good idea! A bit busy these days so if you have a quick fix in mind, please go ahead and change the code. Otherwise I'll take a look soon!
There was a problem hiding this comment.
actually, i tested the current behavior is as long as you are invoking Swiper: Swiper Search/Resume without changing the query string, it keeps track of the item last picked.
Can you try again?
|
thanks for the contribution. sorry for the delay, i had to setup my new laptop, and now i have it setup already, so should be faster iteration from now on . |
Fixes #9 - tested on my local setup.
cc @wenhoujx