Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error 400 when rendering images from Samsung devices? #194

Closed
tkoenig opened this issue Oct 11, 2019 · 3 comments
Closed

Error 400 when rendering images from Samsung devices? #194

tkoenig opened this issue Oct 11, 2019 · 3 comments
Assignees
@kleisauke
Labels
bug Something isn't working completed Feature or request has been completed

Comments

@tkoenig
Copy link

tkoenig commented Oct 11, 2019 •
edited
Loading

Here is an example image which brakes on images.weserv.com .
This worked, before, so I assume an libvips upgrade introduced this?

See also lovell/sharp#1578 as a reference.

Might it be possible to explicitly set failOnError: false for libvips in this case too?

Original Image

http://blobby.wsimg.com/go/0296993c-cade-4ae8-8a65-b3172f22a3a0/6e14af04-904c-4654-936e-2bd7e6e08dd8.jpg

Cropping with weserv fails

https://images.weserv.nl/?url=http://blobby.wsimg.com/go/0296993c-cade-4ae8-8a65-b3172f22a3a0/6e14af04-904c-4654-936e-2bd7e6e08dd8.jpg&w=600&h=600&t=square
@andrieslouw andrieslouw added bug Something isn't working triage This issue is being investigated labels Oct 11, 2019
@andrieslouw
Copy link
Member

Related to lovell/sharp#1578 (comment)

kleisauke added a commit that referenced this issue Oct 20, 2019
@kleisauke
Attempt to decode corrupted or invalid images (#194)
dee4ff0 
This should be a safe option to set, given that libvips is continuously fuzzed by OSS-Fuzz.
@kleisauke
Copy link
Member

Fix (dee4ff0) has been rolled out to production.

Cache has been invalidated for the particular image. If you want, you can send us an email with the images that are affected by this bug and need to be purged from cache.

Thanks for reporting!

@kleisauke kleisauke added completed Feature or request has been completed and removed triage This issue is being investigated labels Oct 20, 2019
@tkoenig
Copy link
Author

tkoenig commented Oct 21, 2019

@kleisauke thanks for the fix!

I quickly checked and could not find any images with errors anymore,
so everything is fine from my side.

@tkoenig tkoenig closed this as completed Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kleisauke kleisauke

Labels
bug Something isn't working completed Feature or request has been completed
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tkoenig @andrieslouw @kleisauke