Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropbox image do not open #237

Closed
felipe-ogestor opened this issue Jun 29, 2020 · 3 comments
Closed

Dropbox image do not open #237

felipe-ogestor opened this issue Jun 29, 2020 · 3 comments
Assignees
@kleisauke
Labels
bug Something isn't working completed Feature or request has been completed

Comments

@felipe-ogestor
Copy link

Hello people!

I'm having a problem using some images in the dropbox. Most are ok, but some are returning 404 (even if the image exists and is correct in the dropbox).

Example:
NOT WORKING:
https://images.weserv.nl/?url=ssl%3Awww.dropbox.com%2Fs%2Fevzchi8siz8o01y%2F9c12c99d8934f78b0c2300122cf237ca.jpg%3Fraw%3D1
www.dropbox.com/s/evzchi8siz8o01y/9c12c99d8934f78b0c2300122cf237ca.jpg?raw=1

WORKING:
https://images.weserv.nl/?url=ssl%3Awww.dropbox.com%2Fs%2Fau3ecbvz6ynf8wg%2F059cb502e2a9c19a9a89c20be4fafec7.jpg%3Fraw%3D1
www.dropbox.com/s/au3ecbvz6ynf8wg/059cb502e2a9c19a9a89c20be4fafec7.jpg?raw=1

What can I be doing wrong?
@andrieslouw andrieslouw added the triage This issue is being investigated label Jun 29, 2020
@andrieslouw
Copy link
Member

Strange, both links give 404 here, care to investigate @kleisauke ?

@kleisauke kleisauke added bug Something isn't working started This issue is being worked on and removed triage This issue is being investigated labels Jun 29, 2020
kleisauke added a commit that referenced this issue Jun 29, 2020
@kleisauke
Ensure fragment identifier is removed from the URI (#237)
e13c6e6 
In accordance with RFC 3986.
@kleisauke
Copy link
Member

kleisauke commented Jun 29, 2020 •
edited
Loading

The problem was that Dropbox tried to redirect to a URI with a fragment identifier. These are reserved for client-side processing, and should be removed when performing HTTP(S) requests (RFC3986, Section 3.5).

This has been fixed with commit e13c6e6, which has just been rolled out to production. Thanks for reporting this!

@kleisauke kleisauke added completed Feature or request has been completed and removed started This issue is being worked on labels Jun 29, 2020
@felipe-ogestor
Copy link
Author

Yes, we noticed they were redirecting. We didn't understand why some images worked.

Anyway, thank you for the quick support!

Closing...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kleisauke kleisauke

Labels
bug Something isn't working completed Feature or request has been completed
Milestone
No milestone
Development

No branches or pull requests
3 participants
@andrieslouw @kleisauke @felipe-ogestor