Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filename can't be orientation options #279

Closed
errorID10TMC opened this issue Apr 11, 2021 · 1 comment
Closed

Filename can't be orientation options #279

errorID10TMC opened this issue Apr 11, 2021 · 1 comment
Assignees
@kleisauke
Labels
bug Something isn't working completed Feature or request has been completed

Comments

@errorID10TMC
Copy link

When the filename is one of the orientation or some of the adjustment options it will change the images. An example of this using flip is below.

https://images.weserv.nl/?url=images.weserv.nl/lichtenstein.jpg&w=300&h=300&filename=flip

This image does have the filename of flip but the image is also flipped. This also happens with some filenames that include one of the options.
@kleisauke kleisauke self-assigned this Apr 13, 2021
@kleisauke kleisauke added bug Something isn't working started This issue is being worked on labels Apr 13, 2021
kleisauke added a commit that referenced this issue Apr 13, 2021
@kleisauke
Ensure key-value pairs are parsed correctly (#279)
2bfc6be 
In some cases, key-value pairs could be misinterpreted as value-key
pairs. This occurred for keys that were handled in the nginx module.
@kleisauke
Copy link
Member

The problem was that the query string was parsed incorrectly. In some cases, key-value pairs could be misinterpreted as value-key pairs, as you discovered. This occurred for keys that were handled in the nginx module.

This has been fixed with commit 2bfc6be, which has just been rolled out to production. Thanks for reporting this!

@kleisauke kleisauke added completed Feature or request has been completed and removed started This issue is being worked on labels Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kleisauke kleisauke

Labels
bug Something isn't working completed Feature or request has been completed
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kleisauke @errorID10TMC