Add support for true streaming #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Bump Travis libvips to 8.9.1. - Simplify unit tests. - Add debug mode within the weserv module. - Regenerate expected fixtures. - Update clang-tidy configuration file. - Fix small memory leak in thumbnail. - Add pagePrimary to output=json. - Update third-party modules.
- Bump Travis libvips to 8.9.2. - Incorporate commit libvips/libvips@6f0548d. - Reduce nesting in query.cpp.
Codecov Report
@@ Coverage Diff @@
## 5.x #225 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 50 56 +6
Lines 1509 1585 +76
=========================================
+ Hits 1509 1585 +76
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for true streaming, a new feature that has landed in libvips 8.9.
https://libvips.github.io/libvips/2019/11/29/True-streaming-for-libvips.html
At the time of writing the savers
magicksave(&output=gif) andtiffsave(&output=tiff) has yet to be reworked for the new source/target API (see libvips/libvips#1541). There's a good chance that within libvips 8.10 this has been reworked.In order to maintain backward compatibility, this feature is therefore conditionally excluded with:
#if VIPS_VERSION_AT_LEAST(8, 10, 0)However, it can be tested earlier by compiling the master branch of libvips.