feat: handle validation error #107
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mukezhz
requested review from
sushanpth,
dipeshdulal,
Denes-cilwal and
paudelgaurav
dipeshdulal
reviewed
Apr 25, 2024
Comment on lines
+36
to
+52
| func HandleValidationError(logger framework.Logger, c *gin.Context, err error) { | ||
| logger.Error("VALIDATION ERROR:", err) | ||
| var ve validator.ValidationErrors | ||
| if errors.As(err, &ve) { | ||
| out := make([]ErrorMsg, len(ve)) | ||
| for i, fe := range ve { | ||
| out[i] = ErrorMsg{ | ||
| fe.Field(), | ||
| fe.Namespace(), | ||
| getErrorMsg(fe), | ||
| } | ||
| } | ||
| ErrorJSON(c, http.StatusBadRequest, out) | ||
| } else { | ||
| ErrorJSON(c, http.StatusBadRequest, err.Error()) | ||
| } | ||
| } |
There was a problem hiding this comment.
This is good implementation.
How about doing it automatically in HandleError function in case we have validation error so that we don't need to pass different error handlers everytime.
What do you think? @mukezhz
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.