Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix serialization of bytes for attachments #83

Merged
merged 4 commits into from
Oct 26, 2023
Merged

fix serialization of bytes for attachments #83

merged 4 commits into from
Oct 26, 2023

Conversation

joshuadavidthomas
Copy link
Member

closes #82

jefftriplett
jefftriplett approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@jefftriplett jefftriplett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. It's hard to eyeball the base64+binascii but the tests look like it's covering enough that it looks safe to me.

@joshuadavidthomas joshuadavidthomas marked this pull request as ready for review October 26, 2023 21:17
@joshuadavidthomas joshuadavidthomas merged commit 3bedcbd into main Oct 26, 2023
25 checks passed
@joshuadavidthomas joshuadavidthomas deleted the issue-82 branch October 26, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jefftriplett jefftriplett jefftriplett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error with attachment: "Object of type bytes is not JSON serializable"
2 participants
@joshuadavidthomas @jefftriplett