Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated version property in docker compose files #163

Merged
merged 2 commits into from
May 14, 2024

Conversation

@joshuadavidthomas joshuadavidthomas requested a review from a team as a code owner May 14, 2024 21:14
@jefftriplett
Copy link

jefftriplett commented May 14, 2024

I have been dropping these for a while. I think VS Code was confused by it (more or less a Linux thing) but that hasn't been for a while.

@joshuadavidthomas
Copy link
Member Author

joshuadavidthomas commented May 14, 2024

@jefftriplett I haven't thought about it, just been mindlessly adding it, until today when I updated Docker and it started logging:

WARN[0000] /home/josh/projects/webtools/compose.yml: `version` is obsolete`

@joshuadavidthomas joshuadavidthomas merged commit 9bc2e12 into main May 14, 2024
6 checks passed
@joshuadavidthomas joshuadavidthomas deleted the remove-compose-version branch May 14, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants