Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📚 Add placeholder mkdocs.yml #204

Merged
merged 4 commits into from
Jul 2, 2024
Merged

📚 Add placeholder mkdocs.yml #204

merged 4 commits into from
Jul 2, 2024

Conversation

williln
Copy link
Contributor

@williln williln commented Jul 1, 2024

Closes #203

@williln williln requested a review from a team as a code owner July 1, 2024 20:10
@williln williln marked this pull request as draft July 1, 2024 20:19
@williln williln marked this pull request as ready for review July 1, 2024 20:24
joshuadavidthomas
joshuadavidthomas approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@joshuadavidthomas joshuadavidthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind adding a quick blurb to the CHANGELOG before merging?

@williln
Copy link
Contributor Author

williln commented Jul 2, 2024

@joshuadavidthomas Did I add it in the right spot?

joshuadavidthomas
joshuadavidthomas approved these changes Jul 2, 2024
View reviewed changes
Copy link
Member

@joshuadavidthomas joshuadavidthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@williln williln merged commit 145a21f into main Jul 2, 2024
6 checks passed
@williln williln deleted the 203-add-mkdocs branch July 2, 2024 17:05
@joshuadavidthomas joshuadavidthomas mentioned this pull request Jul 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuadavidthomas joshuadavidthomas joshuadavidthomas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add mkdocs.yml config file to template
2 participants
@williln @joshuadavidthomas