-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add CACHES to settings, defaulting to locmem #319
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm waffling on what the default should be. I think it's fine/safe to start with this, but if something comes up, we might want to make default to Django's default https://docs.djangoproject.com/en/5.1/topics/cache/#local-memory-caching
Also, we probably need to make sure our test settings have dummycache or keep that in mind in case we see anything weird pop up.
@jefftriplett Re: the dummycache, that's already in place django-twc-project/src/django_twc_project/tests/settings.py.jinja Lines 9 to 13 in 59edc06
What about checking for the presence of the |
Ah, you can set the localmem via the cache url https://github.com/epicserve/django-cache-url#supported-caches
I'm not opposed to that, but like I mentioned in one of our most recent meetings my only worry would be memory usage and how our applications are currently deployed. I've never done any benchmarking around this, so I do not know how much memory the caching would take and whether it would make a measurable difference where we would have to bump the specs up on the app machines. If you have some experience in this area, I'm all ears. |
On the other hand, I probably run those machines a little too close to the edge in terms of allocated memory, so maybe they could all stand to be bumped a bit. 🤷 |
Yes, but this is the default, and we aren't seeing any apps run out of memory. I think the change is fine, but there might be a non-zero impact if we were to set it to one of fly's persistent volumes. (which we aren't using) |
Ok, you've convinced me. I'm probably being a bit overly worried about it anyway. |
No description provided.