fix: celo tx type detection - fixes #1863

wevm · Mar 3, 2024 · 367eef3 · 367eef3
1 parent 1dafba5
commit 367eef3
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 6 deletions.
diff --git a/.changeset/violet-olives-push.md b/.changeset/violet-olives-push.md
@@ -0,0 +1,5 @@
+---
+"viem": patch
+---
+
+Fixed issue where zero gas fees would bypass Celo's transaction type detection.
diff --git a/src/chains/celo/utils.test.ts b/src/chains/celo/utils.test.ts
@@ -83,7 +83,7 @@ describe('isEIP1559', () => {
         maxPriorityFeePerGas: 0n,
         from: mockAddress,
       }),
-    ).toBe(false)
+    ).toBe(true)
 
     expect(
       isEIP1559({
@@ -97,15 +97,15 @@ describe('isEIP1559', () => {
         maxPriorityFeePerGas: 456n,
         from: mockAddress,
       }),
-    ).toBe(false)
+    ).toBe(true)
 
     expect(
       isEIP1559({
         maxFeePerGas: 123n,
         maxPriorityFeePerGas: 0n,
         from: mockAddress,
       }),
-    ).toBe(false)
+    ).toBe(true)
 
     expect(
       isEIP1559({
@@ -279,7 +279,7 @@ describe('isCIP64', () => {
         maxPriorityFeePerGas: 456n,
         from: mockAddress,
       }),
-    ).toBe(false)
+    ).toBe(true)
   })
 
   expect(

diff --git a/src/chains/celo/utils.ts b/src/chains/celo/utils.ts
@@ -33,8 +33,8 @@ export function isEIP1559(
   transaction: CeloTransactionSerializable | CeloTransactionRequest,
 ): boolean {
   return (
-    isPresent(transaction.maxFeePerGas) &&
-    isPresent(transaction.maxPriorityFeePerGas)
+    typeof transaction.maxFeePerGas !== 'undefined' &&
+    typeof transaction.maxPriorityFeePerGas !== 'undefined'
   )
 }