Use abi param names with key remapping for functions with fully named inputs

[fubhy]

I'm sure this has been debated before but is there a reason why functions with fully named inputs do not use typescript key remapping to generate an object type instead of an unnamed tuple?

I see that there are already utils for handling this case, but they are not used for AbiParameters. Hence, I'm curious... Why not sth. like this?

type AbiParametersToPrimitiveTypes<TAbiParameters extends readonly AbiParameter[], TAbiParameterKind extends AbiParameterKind = AbiParameterKind> = _HasUnnamedAbiParameter<TAbiParameters> extends true ? readonly [
    ...{
        [K in keyof TAbiParameters]: AbiParameterToPrimitiveType<TAbiParameters[K], TAbiParameterKind>;
    }
] : {
    [K in TAbiParameters[number] as K extends {
        name: string
    } ? K['name'] : never]: AbiParameterToPrimitiveType<K, TAbiParameterKind>;
};

[fubhy]

The same could be done for outputs of course (if all outputs are named). I'm sure I'm missing sth. here :-)

[jxom]

Is this discussion along the lines of what you mean? pancakeswap/pancake-frontend#6558 (reply in thread)

[jxom]

And this: #346

[jxom]

Basically, introducing an object shape would introduce ambiguity between a “struct”ish tuple and a “positional” tuple – we feel like they should be treated separately to avoid confusion.

[fubhy]

Ok that makes sense. And dynamically named tuples would be dope indeed. Thanks for clarifying.

[fubhy]

I feel like this would be a great candidate for a FAQ :-P. Seems like that question comes up frequently.

[tmm]

Added!

https://github.com/wagmi-dev/viem/blob/main/.github/FAQ.md#why-are-contract-function-args-with-fully-named-inputs-represented-as-unnamed-tuple-types-instead-of-object-types

[emretepedev]

Is there any update for this feature? @tmm
It would be nice to have a function like toObject() as in Ethers v6.

[tmm]

No update. You should implement something in userland if you want this feature.