Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: recoverTransactionAddress #1977

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Conversation

jxom
Copy link
Member

@jxom jxom commented Mar 19, 2024

PR-Codex overview

This PR adds a new function recoverTransactionAddress to recover signing addresses from transactions.

Detailed summary

  • Added recoverTransactionAddress function to recover signing addresses from transactions
  • Updated test files to include tests for recoverTransactionAddress
  • Updated documentation for recoverTransactionAddress
  • Modified assertTransaction.ts to remove gasPrice validation
  • Updated usage examples for recoverTransactionAddress

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Mar 19, 2024

🦋 Changeset detected

Latest commit: b806480

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
viem Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Mar 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
viem ✅ Ready (Inspect) Visit Preview Mar 19, 2024 7:39am

Copy link
Contributor

github-actions bot commented Mar 19, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
viem (esm) 66.23 KB (0%) 1.4 s (0%) 341 ms (-5.99% 🔽) 1.7 s
viem (cjs) 86.03 KB (0%) 1.8 s (0%) 287 ms (-43.46% 🔽) 2.1 s
viem (minimal surface - tree-shaking) 3.72 KB (0%) 75 ms (0%) 6 ms (-12.48% 🔽) 81 ms
viem/accounts 91.45 KB (0%) 1.9 s (0%) 201 ms (-7.6% 🔽) 2.1 s
viem/accounts (tree-shaking) 21.08 KB (0%) 422 ms (0%) 55 ms (+104.4% 🔺) 477 ms
viem/actions 46.62 KB (0%) 933 ms (0%) 122 ms (-0.68% 🔽) 1.1 s
viem/actions (tree-shaking) 340 B (0%) 10 ms (0%) 2 ms (-9.96% 🔽) 12 ms
viem/chains 29.95 KB (0%) 600 ms (0%) 140 ms (+22.45% 🔺) 739 ms
viem/chains (tree-shaking) 367 B (0%) 10 ms (0%) 2 ms (-18.48% 🔽) 12 ms
viem/chains/utils 1.16 KB (0%) 24 ms (0%) 5 ms (-57.37% 🔽) 29 ms
viem/ens 46.62 KB (0%) 933 ms (0%) 33 ms (-33.82% 🔽) 966 ms
viem/ens (tree-shaking) 20.61 KB (-0.02% 🔽) 413 ms (-0.02% 🔽) 28 ms (-51.7% 🔽) 440 ms

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 67.27273% with 36 lines in your changes are missing coverage. Please review.

Project coverage is 97.35%. Comparing base (341fcec) to head (467c941).
Report is 2 commits behind head on main.

❗ Current head 467c941 differs from pull request most recent head b806480. Consider uploading reports for the commit b806480 to get more accurate results

Files Patch % Lines
src/utils/signature/recoverTransactionAddress.ts 53.22% 29 Missing ⚠️
src/utils/transaction/serializeTransaction.ts 82.92% 5 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1977      +/-   ##
==========================================
- Coverage   99.76%   97.35%   -2.42%     
==========================================
  Files         576      572       -4     
  Lines       50649    50400     -249     
  Branches     2523     2269     -254     
==========================================
- Hits        50531    49067    -1464     
- Misses        104     1305    +1201     
- Partials       14       28      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jxom jxom force-pushed the jxom/recover-transaction-address branch from 467c941 to b806480 Compare March 19, 2024 07:35
@jxom jxom merged commit ffacb1b into main Mar 19, 2024
9 of 11 checks passed
@jxom jxom deleted the jxom/recover-transaction-address branch March 19, 2024 07:35
@github-actions github-actions bot mentioned this pull request Mar 19, 2024
@tmm tmm mentioned this pull request Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant