Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: minimize redundant requests in prepareTransactionRequest #2021

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

jxom
Copy link
Member

@jxom jxom commented Mar 26, 2024

Addresses #2017


PR-Codex overview

This PR focuses on minimizing redundant requests in the prepareTransactionRequest function by optimizing fee calculations.

Detailed summary

  • Removed redundant getBlock request
  • Optimized fee calculations based on request parameters
  • Improved error handling for fee calculations

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Mar 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
viem ✅ Ready (Inspect) Visit Preview Mar 26, 2024 8:33pm

Copy link

changeset-bot bot commented Mar 26, 2024

🦋 Changeset detected

Latest commit: 98f6936

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
viem Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.40%. Comparing base (a5675ab) to head (f18bbe1).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2021      +/-   ##
==========================================
- Coverage   99.73%   96.40%   -3.34%     
==========================================
  Files         594      594              
  Lines       53949    53906      -43     
  Branches     2602     2271     -331     
==========================================
- Hits        53804    51966    -1838     
- Misses        130     1917    +1787     
- Partials       15       23       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jxom jxom merged commit 8a173cc into main Mar 26, 2024
5 of 20 checks passed
@jxom jxom deleted the jxom/prepare-tx-request-refactor branch March 26, 2024 20:29
@github-actions github-actions bot mentioned this pull request Mar 26, 2024
@tmm tmm mentioned this pull request Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant