Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: zksync smart account #2598

Merged
merged 9 commits into from
Aug 21, 2024
Merged

feat: zksync smart account #2598

merged 9 commits into from
Aug 21, 2024

Conversation

jxom
Copy link
Member

@jxom jxom commented Aug 8, 2024

Supersedes #2409.


PR-Codex overview

This PR enhances ZKsync by adding toSmartAccount functionality, updating sidebar links, and refining smart account creation.

Detailed summary

  • Added toSmartAccount in ZKsync.
  • Updated sidebar links for Smart Accounts.
  • Refined smart account creation functions.
  • Improved testing for toSinglesigSmartAccount.

The following files were skipped due to too many changes: src/zksync/accounts/toSinglesigSmartAccount.test.ts, src/zksync/accounts/toMultisigSmartAccount.test.ts, src/zksync/accounts/toSmartAccount.test.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Aug 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
viem ✅ Ready (Inspect) Visit Preview Aug 14, 2024 9:38pm

Copy link

changeset-bot bot commented Aug 8, 2024

🦋 Changeset detected

Latest commit: b63cc67

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
viem Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jxom jxom changed the title Zksync smart account feat: zksync smart account Aug 8, 2024
Copy link
Contributor

github-actions bot commented Aug 8, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
import * from 'viem' (esm) 60.31 KB (0%) 1.3 s (0%) 13.6 s (+110.13% 🔺) 14.8 s
const viem = require('viem') (cjs) 70.89 KB (0%) 1.5 s (0%) 17.3 s (+4.73% 🔺) 18.7 s
import { createClient, http } from 'viem' 6.22 KB (0%) 125 ms (0%) 496 ms (+34.95% 🔺) 620 ms
import * from 'viem/account-abstraction' 43.72 KB (0%) 875 ms (0%) 7.4 s (+52.06% 🔺) 8.3 s
import { toCoinbaseSmartAccount } from 'viem/account-abstraction' 33.96 KB (0%) 680 ms (0%) 7.9 s (-2.98% 🔽) 8.6 s
import * from 'viem/accounts' 74.4 KB (0%) 1.5 s (0%) 3.7 s (-12.85% 🔽) 5.2 s
import { privateKeyToAccount } from 'viem/accounts' 19.43 KB (0%) 389 ms (0%) 2.6 s (-49.88% 🔽) 3 s
import * from 'viem/actions' 45.88 KB (0%) 918 ms (0%) 7.9 s (-31.05% 🔽) 8.8 s
import { getBlockNumber } from 'viem/actions' 318 B (0%) 10 ms (0%) 98 ms (+197.41% 🔺) 108 ms
import * from 'viem/chains' 31.07 KB (0%) 622 ms (0%) 6.4 s (+58.16% 🔺) 7 s
import { mainnet } from 'viem/chains' 324 B (0%) 10 ms (0%) 98 ms (+179.88% 🔺) 108 ms
import * from 'viem/chains/utils' 1.08 KB (0%) 22 ms (0%) 91 ms (+16.86% 🔺) 112 ms
import * from 'viem/ens' 45.42 KB (0%) 909 ms (0%) 6.8 s (+22.92% 🔺) 7.7 s
import { getEnsAvatar } from 'viem/ens' 22.13 KB (0%) 443 ms (0%) 7 s (+62.35% 🔺) 7.5 s
import * from 'viem/siwe' 30.24 KB (0%) 605 ms (0%) 5.8 s (+21% 🔺) 6.4 s
import { verifySiweMessage } from 'viem/siwe' 29.15 KB (0%) 584 ms (0%) 4.7 s (-37.22% 🔽) 5.3 s

Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.08%. Comparing base (3749838) to head (b63cc67).
Report is 21 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2598      +/-   ##
==========================================
- Coverage   99.66%   97.08%   -2.59%     
==========================================
  Files         771      773       +2     
  Lines       69455    69593     +138     
  Branches     3271     2926     -345     
==========================================
- Hits        69224    67562    -1662     
- Misses        217     2015    +1798     
- Partials       14       16       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant