Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change klaytn to kaia chain #2643

Merged
merged 4 commits into from
Aug 27, 2024
Merged

Conversation

0oooooooo0
Copy link
Contributor

@0oooooooo0 0oooooooo0 commented Aug 22, 2024

This Pull Request proposes the rebranding of the Klaytn Chain to the Kaia Chain, effective from August 29th. The changes include the following:

All instances of "Klaytn" have been updated to "Kaia" throughout the codebase and documentation.
The KlaytnBaobab testnet has been renamed to "Kairos." All references to "KlaytnBaobab" have been updated accordingly.
Please review the changes and provide feedback. If everything is in order, I would appreciate it if this PR could be merged by or before August 29th to ensure a smooth transition.

For more details about the chain rebranding, please refer to the official announcement here.


PR-Codex overview

The focus of this PR is to add support for the Kaia chain and deprecate klaytn in favor of kaia and kairos.

Detailed summary

  • Added Kaia chain with details
  • Deprecated klaytn, use kaia instead
  • Added kairos chain
  • Updated klaytn and klaytnBaobab chains with new details

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Aug 22, 2024

🦋 Changeset detected

Latest commit: c10ea8e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
viem Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Aug 22, 2024

@0oooooooo0 is attempting to deploy a commit to the Wevm Team on Vercel.

A member of the Team first needs to authorize it.

@jxom jxom self-requested a review August 22, 2024 21:23
@@ -1,20 +1,20 @@
import { defineChain } from '../../utils/chain/defineChain.js'

export const klaytn = /*#__PURE__*/ defineChain({
export const kaia = /*#__PURE__*/ defineChain({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export const kaia = /*#__PURE__*/ defineChain({
export const klaytn = /*#__PURE__*/ defineChain({

@@ -1,21 +1,21 @@
import { defineChain } from '../../utils/chain/defineChain.js'

export const klaytnBaobab = /*#__PURE__*/ defineChain({
export const kairos = /*#__PURE__*/ defineChain({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export const kairos = /*#__PURE__*/ defineChain({
export const klaytnBaobab = /*#__PURE__*/ defineChain({

Copy link
Member

@jxom jxom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid breaking changes, can you please keep the original exports for these chains under a /** @deprecated */ flag and also add new files for the new chains? We can keep the rebranding in the old chains too.

Example:
https://github.com/wevm/viem/blob/main/src/chains/index.ts#L226-L227

@0oooooooo0
Copy link
Contributor Author

To avoid breaking changes, can you please keep the original exports for these chains under a /** @deprecated */ flag and also add new files for the new chains? We can keep the rebranding in the old chains too.

Example: https://github.com/wevm/viem/blob/main/src/chains/index.ts#L226-L227

I completed it! thank you

@0oooooooo0
Copy link
Contributor Author

@jxom Do you check it? Kaia will launch after 2 days. so I hope it merges quickly

@jxom jxom merged commit 8ac740e into wevm:main Aug 27, 2024
2 of 4 checks passed
@github-actions github-actions bot mentioned this pull request Aug 27, 2024
@0oooooooo0 0oooooooo0 deleted the change-klaytn-to-kaia branch August 27, 2024 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants