Proper Content-Type header on CCIP POST requests #2876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@m1guelpf is attempting to deploy a commit to the Wevm Team on Vercel. A member of the Team first needs to authorize it. |
🦋 Changeset detectedLatest commit: ada370f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Merged
nikola-bozin-txfusion
pushed a commit
to kiriyaga-txfusion/viem
that referenced
this pull request
Oct 30, 2024
* Proper Content-Type header on CCIP POST requests * Update ccip.ts * Create dirty-hounds-lay.md --------- Co-authored-by: jxom <j@wevm.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, CCIP POST requests are sent without
Content-Typeheaders, which makes requests fail for servers that reject the body if the header isn't present.PR-Codex overview
This PR focuses on enhancing the CCIP functionality by ensuring that
POSTrequests include the appropriateContent-Typeheader, which is essential for correctly indicating the format of the data being sent.Detailed summary
ccip.tsfile, aheadersobject is created forPOSTrequests, settingContent-Typetoapplication/json.fetchcall is updated to include the newly createdheadersobject.