fix: do not use generic type variables for getAbiItem return type #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: db822ea The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Size Change: 0 B Total Size: 246 kB ℹ️ View Unchanged
|
tmm
approved these changes
Apr 12, 2023
Co-authored-by: awkweb <tom@meagher.co>
Codecov Report
@@ Coverage Diff @@
## main #365 +/- ##
==========================================
- Coverage 99.89% 99.88% -0.01%
==========================================
Files 264 264
Lines 19714 19715 +1
Branches 1845 1848 +3
==========================================
Hits 19693 19693
- Misses 19 20 +1
Partials 2 2
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's imho good practice to avoid using generic type variables directly in return types. It creates a chicken & egg scenario when the return of such a function is then used in another generic function's input as seen in #359
Automated Summary
🤖 Generated by Copilot at db822ea
This pull request fixes the
getAbiItemfunction to simplify its type signature and return type. It also adds a changeset file to document the patch version update and the bug fix for theviempackage.