feat: esm-only #1173
Merged
feat: esm-only #1173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: a1b5b9f The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jxom
reviewed
Oct 27, 2022
jxom
reviewed
Oct 27, 2022
jxom
reviewed
Oct 27, 2022
jxom
reviewed
Oct 27, 2022
tmm
force-pushed
the
tmm/tsup-esm
branch
4 times, most recently
from
d4d2fac
to
8f0a9de
Compare
jxom
approved these changes
Oct 28, 2022
tmm
added a commit
that referenced
this pull request
Nov 9, 2022
* docs: start migration guide * feat: esm-only (#1173) * wip: set up tsup * wip: working examples * build: tsc * fix: recursive conditional return types * refactor: remove preconstruct references * feat: dev mode * refactor: tsup config * chore: add changeset * build: validate exports * fix: jsx runtime import issue * chore: add types to package.json exports * refactor: addressOrName to address (#1203) * refactor: remove deprecated testnets + make `apiKey` required (#1185) * feat: make apiKey required on providers * tech-debt: remove deprecated testnets * chore: docs + changesets * chore: update tsdoc * chore: update migration guide * fix: lint error Co-authored-by: jxom <jakemoxey@gmail.com>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR converts
wagmifrom bundling both CJS + ESM, to bundling pure ESM.This will probably affect tooling that is sensitive to importing ESM such as Jest and Remix. We might need to create some additional guides on how to use wagmi with these tools as we move to pure ESM.
Evolution of #933 using tsup instead of patching Preconstruct
Fixes #838
Fixes #1004
Additional Information
Your ENS/address: awkweb.eth