Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation kick off: Simplified Chinese #1551

Merged
merged 6 commits into from
Jan 11, 2023
Merged

Translation kick off: Simplified Chinese #1551

merged 6 commits into from
Jan 11, 2023

Conversation

noyyyy
Copy link
Contributor

@noyyyy noyyyy commented Dec 22, 2022

Note: Translation Progress discussion: #1582

Description

Start the translation of Simplified Chinese with configuration and two mdx.

There is a discussion before #1461.

Translation would be long progress and will be fulfilled with many pr. So, I'd like to create a discussion to record the translation progress and people can translate it one page by one page.

Additional Information

Your ENS/address: 0x7E480e349a31F71f59B57cb30Bd850b4D643D617

@changeset-bot
Copy link

changeset-bot bot commented Dec 22, 2022

⚠️ No Changeset found

Latest commit: 8f47278

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Dec 22, 2022

@noyyyy is attempting to deploy a commit to the wagmi Team on Vercel.

A member of the Team first needs to authorize it.

@tmm tmm marked this pull request as draft December 22, 2022 17:54
@vercel
Copy link

vercel bot commented Dec 22, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
wagmi ✅ Ready (Inspect) Visit Preview Dec 30, 2022 at 5:44PM (UTC)

@tmm
Copy link
Member

tmm commented Dec 25, 2022

Excited for this! I can send a tweet out to the community next week to see if there is anyone else interested in helping with this.

@noyyyy
Copy link
Contributor Author

noyyyy commented Dec 28, 2022

Do I need to make some commits to make the test pass? Also, I make a draft translation progress record in discussion #1582

@tmm
Copy link
Member

tmm commented Dec 28, 2022

I wouldn't worry about the tests. I think you need to add a ANVIL_FORK_URL environment variable to your fork to get it to run correctly.

Let's link the discussion thread to the PR description so folks can discover it more easily.

@noyyyy
Copy link
Contributor Author

noyyyy commented Dec 30, 2022

I think this pr is ready to be merged if there are no other problems, and translation by page can start. I will send a tweet about this and create a telegram group for communication besides translation.

Btw, I set ANVIL_FORK_URL in my forked repo but it fails. I try to run the test locally and some tests still fail. What should I do next?

@noyyyy noyyyy marked this pull request as ready for review December 30, 2022 17:23
@noyyyy
Copy link
Contributor Author

noyyyy commented Jan 4, 2023

Just pulled some commits from upstream and the test passes this time in my repo. https://github.com/noyyyy/wagmi/actions/runs/3839220790
Can not wait to see its merge!

@noyyyy
Copy link
Contributor Author

noyyyy commented Jan 11, 2023

Hi @tmm, didn't receive your comment. How do we move forward next?

@tmm
Copy link
Member

tmm commented Jan 11, 2023

@noyyyy merging in! I hid all untranslated pages so as they are translated, you can unhide them by removing "display": "hidden" from _meta.zh-CN.json.

@tmm tmm merged commit 8653a91 into wevm:main Jan 11, 2023
@noyyyy
Copy link
Contributor Author

noyyyy commented Jan 11, 2023

@noyyyy merging in! I hid all untranslated pages so as they are translated, you can unhide them by removing "display": "hidden" from _meta.zh-CN.json.

Get it. Will continue translating with community.

@tmm
Copy link
Member

tmm commented Jan 11, 2023

Sounds great! Feel free to @ mention me in any PRs or discussion if I can be helpful. 谢谢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants